Why Does Not Cactiverecord#hasattribute() Check Property_Exists()

Yii 1.1 General Discussion
1

Hi

I noticed that CActiveRecord#setAttribute() sets value into to its property,

when model has that property, by checking with property_exists().

But in hasAttribute() method, the object property is never checked.

does anyone know the reason about that?

2

Interesting. It seems it’s either a small bug or the documentation’s wrong. The thing is, it’s possible to add non-table-field-related “fake” attributes to CActiveRecords, and while getAttribute and setAttribute are properly checking that first, hasAttribute does not, even though its documentation states “Checks whether this AR has the named attribute”.

So either the documentation should read “Checks whether this AR’s table has the named attribute as a field”, or the function should be changed to


	public function hasAttribute($name)

	{

		return property_exists($name) || isset($this->getMetaData()->columns[$name]);

	}

Maybe you should report this.

3

Thanks Siquo,

I’ve just submitted an isseu #2496