Where to post a patch?

Hi There,

I was wondering if it is possible to post a patch for one or more files in the Yii framework? And where to do that?

In my case it is a simple change in a javascript file that I want to purpose. There was no easy way to work around it, so I changed the code in the framework code. It’s a very small change (which can’t really effect any operational code) so I would think it no problem to add the change in the next release. But I have no clue where to put it, because it is really a bug and really to small to be a feature.

BTW, The patch file content for the file I changed (jquery.yiilistview.js) is:

# This patch file was generated by NetBeans IDE

# It uses platform neutral UTF-8 encoding and \n newlines.

--- 519

+++ 520

@@ -108,7 +108,7 @@


 		if(settings.beforeAjaxUpdate != undefined)


-		$.ajax(options);

\ No newline at end of file

+		return $.ajax(options); //it never hurts to return something <img src='http://www.yiiframework.com/forum/public/style_emoticons/default/wink.gif' class='bbc_emoticon' alt=';)' />

\ No newline at end of file




If you use git… the best way would be to create a pull request…

Is this related to the your other thread - http://www.yiiframew…__1#entry142117

It’s not use to open new threads… for future… it’s better to continue posting on the same thread for the same problem/request…

To implement this in Yii, as you mentioned in the first thread, it would be needed to make the same functionality for listview and gridview.

Thanks for your reply!

I’ll try to create a pull request.

Yes, it is related.

I know, sorry 'bout that :unsure:… Guess I was desperate for a reply :rolleyes:

Good point!