Problem with pagination/summary count

darjona · June 28, 2024, 7:51am

Hi all,

I am using the pagination/summary count in some GridView to display the retrieved records number, and it worked fine with version 2.0.49.3 or below, but since I upgraded to 2.0.50 version, it shows the count wrong.

The data is displayed correctly, even when I apply some filter the data is stillvdisplaying well, but the pagination shows all the records, like if I don’t have any filter applied.

I know the error started when I updated, because if I downgrade to 2.0.49.3, the paginator/summary works fine again.

With version 2.0.49.3

With version 2.0.50
(I can’t upload more media as I am a new user. However, it’s the same as the above, but with 650.000 records instead of 7.000)

The code hasn’t been modified between versions. I am using the default Yii GridView.

Some ideas? Some bug already registered?

Thanks!!

tri · June 28, 2024, 8:02am

github.com/yiisoft/yii2

Bug: DataProvider total count is incorrect

opened 01:48PM - 25 Jun 24 UTC

srdjan92

I am still not sure if this is a bug, but the Yii2 search used to work fine with this approach for years. In the application I am working on, we used the following approach, but after the upgrade to version 2.0.50, the total count in the data provider object is not correct anymore. ### What steps will reproduce the problem? ``` public function search() { $query = User::find(); $dataProvider = new ActiveDataProvider([ 'query' => $query, 'pagination' => [ 'pageSize' => 20, 'page' =>!Yii::$app->request->isConsoleRequest ? (int) Yii::$app->request->getQueryParam('page', 0) : 0, ] ]); $this->load($params); if (!$this->validate()) { $query->andWhere("1=0"); return $dataProvider; } //Apply additional filters to the query return $dataProvider; } ``` ### What is the expected result? I expect the correct total count value to be calculated with applied query filters. ### What do you get instead? I got a total count of all records in the table without query filters applied to the query. ### Additional info In the example above, we pass the pagination configuration when the `ActiveDataProvider` instance is created. The pagination object will be created immediately, and the total count in the `Pagination` object will also be populated using the `$query` passed at that point. The issue will not be present if we do not pass the pagination configuration to the data provider. As far as I see, this problem was caused by the following commit https://github.com/yiisoft/yii2/commit/90c0eb02d1768e7f2ab3512e1da5b8475dc5d32d I know how to work around the current issue, but I wanted to bring up this topic because I am afraid it will affect many applications. | Q | A | ---------------- | --- | Yii version | 2.0.50 | PHP version | 8.2 | Operating system | Ubuntu 22