Is it considered bad practice to use Yii::app()->user in models?

Yii 1.1 General Discussion
1

Hey everyone,

question already in the title. Is it considered bad practice to use CWebUser in models? Because I do it all the time in scopes, relations, and so on … Coming across the same issues described in the topics below (exception thrown when Yii::app()->user is called in console applications) I think, I might need to change my current way of handling session information in models.

Related problem:

http://www.yiiframework.com/forum/index.php?/topic/22070-error-handling-in-cwebuser/

http://www.yiiframework.com/forum/index.php?/topic/10260-yiiapp-user-in-console-applications/

Thank you for your feedback!

2

It is ok to use it in model…

I’m not surprises you cant use it in Console …

3

Can you provide some example, how and why you’re using user (CWebUser) in your model?

I’m a beginner in Yii and MVC, but if I understand MVC logic correctly, user should not be used directly in model.

Also, I wrote just a few small apps in Yii, but I never run into need of reffering user in models.

4

Here’s an example of code that I use:

public function relations()


{


	return array(

…

        'added_me' => array(self::HAS_ONE, 'AddedUser', 'from_user_id', 'on'=>'added_me.to_user_id='.Yii::app()->user->id),

…

	);


}
5

Irregardless of whether or not it’s bad practice, I think it would be better to make it more generic. For example:

Instead of checking if the model "added me", it makes more sense to design it so that you can check if the model "added user x". Then you just send in the Yii::app()->user->id as input instead of having it hardcoded in.

6

It is bad practice. What if you need to create new interface on your site, for example manager who can access not only him self, but other users.

Model doesn’t need to know in which context it used. So not using current session and so on making your code more flexible.

p.s. sorry for my english