Handling decimal separators - Wiki article


(Jpablo) #1

Yii i18n does not cover decimal format. Some languages like Spanish (I live in Argentina) uses comma ‘,’ instead of dot ‘.’ as decimal separator.

A localized web app should:

1- Display decimal values with the local decimal separator.

2- Allow entering decimal values with the local decimal separator.

I posted a wiki article explaining a procedure to get it done. Wiki article

Please add your comments, suggestions, etc, here.


(Janek Jan) #2

Why not just using a custom formatter class? It would format values for display changing the separator and if you define static methods you can filter input. I’ve done that and it works like a charm. I’m storing decimal values (currency) with a fixed precision as integers (multiplied by 100) but one can store them in any float format.

Storing proper values in models also helps when doing any calculations.

Filtering this way helps validation anyway, since you can remove common typos before validation (or not).

BTW I’m doing the same with dates, filtering with date(‘Y-m-d’,strtotime($date)) to allow almost any input format, not just Y-m-d that the DB requires.


(Jpablo) #3

Yes, a custom formatter class will work, but you need to declare the class in each grid, each form, etc. The CHtml override take care of the conversion system wide. Your application code will not change at all.

I’m curious, why are you storing decimal values as integer instead of DECIMAL?


(Da:Sourcerer) #4

Nope. You can just register your custom formatter in your config in the components-stanza. Gridviews, detailviews etc. will pick it up automatically ;)


(Janek Jan) #5

I always considered such formats as an unnecessary hassle. AFAIR I’ve never needed it for anything other than monetary values with a fixed scale of 2. Easy to remember, no need to write it down in a schema definition.

Following the PostgreSQL manual (sorry for no link, it looks I’m too new here):

I’m not saying it’s wrong in any way, just my preference. Using decimals would hint any generators using db schema how to build validation rules, but it’s not much effort to correct that by hand, especially if I do it once in a project lifetime. And I like to know where/when/how rounding happens when doing some calculations on user input.

A little digression - recently I learned that ROUND function in a popular spreadsheet software works different in cell expressions than in it’s macro language. And I learned it the hard way - by debugging.


(Jpablo) #6

I understand your point of view on storing decimals in integer fields. I don’t share it, but I understand it =)

Round and decimal precision is a hassle many times in many languages. Javascript, for example, just SUCKS handling decimal precision. Just try this:

Javascript will show 16229.499999999998 instead of 16229.5 !!! So, be warned, handling decimal values in javascript is not safe at all. In fact, it’s dangerous.


(Jpablo) #7

Great! I’ll try it in a couple of hours, then I’ll update the wiki page. Thank you!


(Migarcia) #8

Hi

I have problem with :

foreach($this->owner->getTableSchema()->columns as $name => $column)

owner not exist, and after, the gii fail with :

Missing argument 1 for ModelCode::getTableSchema(), called in D:\Proyectos\tuDulceTarta\web\commonend\helpers\CHtml.php on line 2168 and defined


(Tomvdp) #9

Can you elaborate on that "etc" in your phrase ? It seems only gridviews and detailviews have this ability to format their output. It would have been nice that indeed any component could be instructed to use a formatter, but alas.

Why is there a ‘type’ property foreseen on a CDataColumn, but is it not possible to pass type information when creating for example an activeTextField so that it too would call the appropriate formatter ?

I am currently struggling to get the number formatting correclty for my locale (comma as decimal point).

Looking for a solution I found these:

http://www.yiiframework.com/wiki/298/how-to-handle-decimal-separators-e-g-comma-instead-of-dot-for-l18n

http://www.yiiframework.com/wiki/360/custom-number-formatting-or-decimal-separators-and-i18n/


(Da:Sourcerer) #10

Hm, perhaps I’ve put that etc in there a bit too enthusiasticaly. In fact, I cannot remember any other places where this would be useful stante pede.

As for the solutions in the wiki: I think a behaviour for this would blend in more into Yii. Makes me remember I wanted to publish such a thing :)