FileHelper saveAs and createDirectory issues

amlopezalonso · January 28, 2016, 6:35pm

Hi,

I posted this in #7462 but @SilverFire pointed me out here and blocked the thread before I could even defend myself…

Before the behavior change cited in #7462 I had:

In params-local.php:




 return ['myRoot' => '@web/myroot'];

…and in controller:




$fullPath = Yii::$app->params[$myRoot] . '/myLast';

FileHelper::createDirectory($fullPath); // same behavior with saveAs

and had no trouble with it. Now, following the code replacement recommended in #6289 I have:




FileHelper::createDirectory(Yii::getAlias($fullPath)); //same behavior with saveAs

And it throws:

Exception – yii\base\Exception

Failed to create directory ‘/web’: mkdir(): Permission denied

In summary, I had no permission issues with pre-#7462 code but now I do after applying the recommended replacement and that’s why I assumed my question to properly fit in the context of #7462 rather than posting it in the forums.

Anyway, any idea?

Antonio

softark · January 28, 2016, 11:15pm

In those issues (#7462 and #6289), they were discussing whether aliases should be supported or not for certain circumstances. They were talking about the design, not bugs.

And the issues were closed since the dev team had already decided not to.

github.com

yiisoft/yii2/blob/master/docs/internals/design-decisions.md

Design Decisions
================

This document lists the design decisions that we have made after extensive discussions. Unless there are very strong
reasons, these decisions should be kept for consistency. Any change to these decisions should get agreement among
the core developers.

1. **[When to support path aliases](https://github.com/yiisoft/yii2/pull/3079#issuecomment-40312268)**
   we should support path alias for properties that are configurable because using path aliases in configurations 
   are very convenient. In other cases, we should restrict the support for path aliases.
2. **When to translate messages**
   messages should be translated when these are displayed to non-tech end user and make sense to him. HTTP status messages,
   exceptions about the code etc. should not be translated. Console messages are always in English because of encoding
   and codepage handling difficulties.
3. **[Adding new auth client support](https://github.com/yiisoft/yii2/issues/1652)**
   For better maintainability, we will not add any additional auth clients to the core extension. They should be done 
   in terms of user extensions. 
4. **When using closures** it is recommended to **include all passed parameters** in the signature even if not all of them are
   used. This way modifying or copying code is easier because all information is directly visible and it is not necessary to
   look up which params are actually available in the documentation. ([#6584](https://github.com/yiisoft/yii2/pull/6584), [#6875](https://github.com/yiisoft/yii2/issues/6875))

This file has been truncated. show original

It’s not your fault, but you were asking question about a bug.

In the following 2 codes, createDirectory receives different parameters. It’s normal that one may succeed and the other may fail. Check the parameters passed to createDirectory.




$fullPath = Yii::$app->params[$myRoot] . '/myLast';

FileHelper::createDirectory($fullPath);




$fullPath = Yii::$app->params[$myRoot] . '/myLast';

FileHelper::createDirectory(Yii::getAlias($fullPath));