display validation errors

[caramelon (Decalina)]

Hi,

this is a newbee question.

I’m trying to make a simple app that would just collect data from a form, validate the input, concatenate it if it’s right and display either the concatenated data back or the errors. The rendering of either the errors or the concatenated string should be on the same page where the data is collected.

So far I managed to validate the input, concatenate it and display it.

I’m stucked in displaying the errors. I’d like to display errors as yii does on the login form. I can get the errors using $model->getErrors() on my controller but I don’t seem to be able to render them.

I’ll post the function to concatenate:

public function actionConcatenate()

	{

			if (isset($_POST['CollectData']))

			{

				$model = new CollectData();

				$model->attributes = $_POST['CollectData'];

				

				if($model->validate())

				{

					$model->resultado = implode(', ', $model->attributes);

					$this->render('index', array ('model' => $model));

				}

				else {

					$errores = $model->getErrors();

					$this->render('index', array('model' => $errores));

				}

				

			}

	}

I’d appreciate if you could drive me in the right direction.

Thanks

[mdomba (Maurizio Domba Cerin)]

Posting your view code would help…

Anyway you can use errorSummary() to display the errors - http://www.yiiframework.com/doc/api/1.1/CActiveForm#errorSummary-detail

[caramelon (Decalina)]

Thanks mdomba.

Here’s the view code:

<?php

$this->breadcrumbs=array(

	'Calculator',

);?>

<h1><?php echo $this->id . '/' . $this->action->id; ?></h1>


<div class='form'>


<?php


$model = (isset($model))? $model : new CollectData(); ?>


<?php


if (! empty($model->resultado))

{

	echo "<p>";

	echo "Las palabras concatenadas son: ".$model->resultado;

	echo "</p>";

}

?>


<?php echo CHtml::beginForm('index.php?r=calculator/concatenate', 'post'); ?>


<?php echo CHtml::errorSummary($model); ?>


<div class="row">

<?php echo CHtml::activeLabel($model,'palabra'); ?>

<?php echo CHtml::activeTextField($model,'palabra', array('value'=>'')); ?>

</div>


<div class="row">

<?php echo CHtml::activeLabel($model,'palabra5'); ?>

<?php echo CHtml::activeTextField($model,'palabra5', array('value'=>'')); ?>

</div>


<div class="row">

<?php echo CHtml::activeLabel($model,'numero'); ?>

<?php echo CHtml::activeTextField($model,'numero', array('value'=>'')); ?>

</div>


<?php echo CHtml::submitButton('Submit'); ?>





<?php echo CHtml::endForm(); ?>




</div>

[caramelon (Decalina)]

Oh!

I forgot to mention. All I get when inputing wrong data is a fatal error saying:

Fatal error: Call to a member function getErrors() on a non-object in /opt/lampp/frameworks/yii-1.1.5.r2654/framework/web/helpers/CHtml.php on line 1563

[mdomba (Maurizio Domba Cerin)]

You are using the variable $model for the actual model data and for the concatenated results and errors…

You can use some other variables for the concatenaded values that you can check in the view if they are set like:

if($model->validate())

{

   $this->render('index', array('results' => implode(', ', $model->attributes)));

}

else {

   $this->render('index', array('errors' => $model->getErrors()));

}

[caramelon (Decalina)]

Hi, thanks for the reply.

I’m affraid it still says I’m calling getErrors() on a non-object.

[mdomba (Maurizio Domba Cerin)]

You need to check the value of $model just before calling $model->getErrors()… seems it’s not an object…

[maschingan]

try this:

public function actionConcatenate()

        {

                        if (isset($_POST['CollectData']))

                        {

                                $model = new CollectData();

                                $model->attributes = $_POST['CollectData'];

                                

                                if($model->validate())

                                {

                                        $model->resultado = implode(', ', $model->attributes);

                                }

                                $this->render('index', array ('model' => $model));                                

                        }

        }

do not change your view code, just try this, it’s must work.

[caramelon (Decalina)]

OK, thank you.

It’s fixed now (although not in an elegant way). I’ll try to post the code later for the records.

[caramelon (Decalina)]

try this:

public function actionConcatenate()

        {

                        if (isset($_POST['CollectData']))

                        {

                                $model = new CollectData();

                                $model->attributes = $_POST['CollectData'];

                                

                                if($model->validate())

                                {

                                        $model->resultado = implode(', ', $model->attributes);

                                }

                                $this->render('index', array ('model' => $model));                                

                        }

        }

do not change your view code, just try this, it’s must work.

Oh! I didn’t see your code. I’ll try that later.

[caramelon (Decalina)]

Hi,

thank you both for your answers; I learned from you.

@maschingan, this is exactly what I was looking for.

Let me now sum up what I learned and see if I’m right:

1. on the controller, $model->validate() validates the data and, very important, sets $model->errors

2. on the view file, CHtml::errorSummary($model) handles the whole error report: reads the $model->errors, writes the proper html.

I’d appreciate if you can check if there is anything wrong on what I’ve just said.

In any case, I thank you both.

[maschingan]

yes, you right. Some advice:

You can write

public function actionConcatenate()

        {

                        $model = new CollectData();

                        if (isset($_POST['CollectData']))

                        {

                                $model->attributes = $_POST['CollectData'];

                                

                                if($model->validate())

                                {

                                        $model->resultado = implode(', ', $model->attributes);

                                }

                        }

                         $this->render('index', array ('model' => $model));

        }

and in view remove some lines

<?php

$this->breadcrumbs=array(

        'Calculator',

);?>

<h1><?php echo $this->id . '/' . $this->action->id; ?></h1>


<div class='form'>


<?php


if (! empty($model->resultado))

{

        echo "<p>";

        echo "Las palabras concatenadas son: ".$model->resultado;

        echo "</p>";

}

?>


<?php echo CHtml::beginForm('', 'post'); ?>


<?php echo CHtml::errorSummary($model); ?>


<div class="row">

<?php echo CHtml::activeLabel($model,'palabra'); ?>

<?php echo CHtml::activeTextField($model,'palabra', array('value'=>'')); ?>

</div>


<div class="row">

<?php echo CHtml::activeLabel($model,'palabra5'); ?>

<?php echo CHtml::activeTextField($model,'palabra5', array('value'=>'')); ?>

</div>


<div class="row">

<?php echo CHtml::activeLabel($model,'numero'); ?>

<?php echo CHtml::activeTextField($model,'numero', array('value'=>'')); ?>

</div>


<?php echo CHtml::submitButton('Submit'); ?>





<?php echo CHtml::endForm(); ?>


</div>

and you will be not need two actions in controller (i guess you have two actions for this view).

[caramelon (Decalina)]

Yes I had two actions for this view.

I think I get what you mean: put the most part of the logic on the controller.

Thanks

[nareboy (Felipe Moreira)]

try this:

public function actionConcatenate()

        {

                        if (isset($_POST['CollectData']))

                        {

                                $model = new CollectData();

                                $model->attributes = $_POST['CollectData'];

                                

                                if($model->validate())

                                {

                                        $model->resultado = implode(', ', $model->attributes);

                                }

                                $this->render('index', array ('model' => $model));                                

                        }

        }

do not change your view code, just try this, it’s must work.

Thank you so much! Was my problem too.

[jakhar (Jakharrohi)]

hey guys i have same error

this is my controller

case Yii::app()->par->PAGE_ADD_PRESENTATION :

			if (!Yii::app()->user->id) $this->redirect(array('contenu/'.Yii::app()->par->PAGE_PERSONNEl));


		


			$view = "_contenu_add_presentation";





			// on choisit le template n°3


			$this->layout='ocelles5';





			// on regarde si on propose un nom de presentation ou une place dans l'arborescence


			$place = Yii::app()->request->getQuery('place',NULL);


			$nom = Yii::app()->request->getQuery('nom',NULL);





			// on charge la palette


			$this->palette=$this->loadPalette($this->idconcept);





			// registrer le javascript de gestion d'ajout de presentation


			$cs->registerScriptFile(Yii::app()->baseUrl.'/js/concept_setup.js',CClientScript::POS_HEAD);


			// on va utiliser le script jsTree


			$cs->registerScriptFile($baseUrl.'/js/jquery.jstree.js',CClientScript::POS_HEAD);


			// registrer jqueryui


			$cs->registerCoreScript('jquery.ui');


			// registrer le css (on doit le charger avant d'appeler une éventuelle boite de dialogue)


			$cs->registerCssFile(Yii::app()->getBaseUrl(true) . "/" . Yii::app()->par->PATH_THEME_JQUERYUI . "/" . $this->palette . "/" . $this->palette . ".css");





			// on va utiliser le script jCarousel pour afficher la liste des signes du presentation


			$cs->registerScriptFile($baseUrl.'/js/jquery.jcarousel.min.js');


			$cs->registerScriptFile($baseUrl.'/js/jcarousel_setup.js');


			$cs->registerCssFile($baseUrl.'/css/jcarousel_skins/ocelles/skin_signes.css'); // on utilise un skin particulier





			// on charge le titre de la page


			$this->pageTitle=$this->loadPageTitle($this->idconcept);





				


			// ------------


			// ZONE BANNER


			// ------------


			// on charge la nuance pour la zone banner


			$this->banner_nuance=$this->loadBannerNuance($this->idconcept);





			// on charge le contenu de la zone banner : pour la page presentation il s'agira de la vue banner_presentation


			$this->banner_content = array(


					"type"=>"default",


					"content"=>$this->renderPartial('_view_banner_add_presentation',array(


							"place"=>$place,


							"nom"=>$nom


					),true,false)


			);





			// ----------------


			// ZONE PRINCIPALE


			// ----------------


			// on charge la nuance de la palette


			$this->content_nuance = $this->loadNuance($this->idconcept);





			$this->render($view,array(


					"place"=>$place,


					"nom"=>$nom


			));





			break;

this is view file

<?php

// VUE CONCEPT => contenu de la page concept

?>

<div class="concept_main_action first <?php echo $this->palette;?> n3">

<?php if (Yii::app()->user->id){

$link = array(‘contenu/’.Yii::app()->par->PAGE_ADD_PRESENTATION);

$traduction = Ocelles::getTraduction(Yii::app()->par->PAGE_ADD_PRESENTATION);

$trad = Ocelles::getTraduction(Yii::app()->par->INTERFACE_PRESENTATION_CREER);


MyFunctions::displayTraduction($trad["traductionid"],"traduction survol_video");


echo CHtml::link("Créer une présentation",array('contenu/view','id'=>Yii::app()->par->PAGE_ADD_PRESENTATION),array("title"=>"Créer une présentation"));


} else {


	$link = array('contenu/'.Yii::app()->par->PAGE_PERSONNEL);


	$traduction = Ocelles::getTraduction(Yii::app()->par->PAGE_PERSONNEL);


	$trad = Ocelles::getTraduction(Yii::app()->par->INTERFACE_PRESENTATION_CREER);	


	MyFunctions::displayTraduction($trad["traductionid"],"traduction survol_video");


	echo CHtml::link("Créer une présentation",array('contenu/view','id'=>Yii::app()->par->PAGE_ADD_PRESENTATION),array("title"=>"Créer une présentation"));


	}


?>

</div>

<div class="concept_main_action_icon first">

<?php echo CHtml::link(Chtml::image(Yii::app()->baseUrl . "/" . Yii::app()->par->PATH_IMAGES . "concept_add_signe.png","Créer une présentation"),array('contenu/view','id'=>Yii::app()->par->PAGE_ADD_PRESENTATION),array("title"=>"Créer une présentation"));?>

</div>

<div class="concept_main_action <?php echo $this->palette;?> n3">

<?php 


$trad = Ocelles::getTraduction(Yii::app()->par->INTERFACE_DERNIERES_PRESENTATIONS);


MyFunctions::displayTraduction($trad["traductionid"],"traduction survol_video");


echo CHtml::link("Dernières présentation ajoutées",array(''),array("title"=>"Dernières présentation ajoutées","onclick"=>"js:$('#dernieres_pages').slideToggle('slow');return false;"));


?>

</div>

<div class="concept_main_action_icon">

<?php echo CHtml::link(Chtml::image(Yii::app()->baseUrl . "/" . Yii::app()->par->PATH_IMAGES . "concept_add_signe.png","Dernières présentation ajoutées"),array(''),array("title"=>"Dernières présentation ajoutées","onclick"=>"js:$('#dernieres_pages').slideToggle('slow');return false;"));?>

</div>

<div id="dernieres_pages">

<?php


$limite = 0;


$concepts = Ocelles::getConcepts(Yii::app()->user->id);


foreach ($concepts as $key=>$concept) {


	$limite++;


	if ($limite == 9) break;


	$icone = Ocelles::getIcone($key,Yii::app()->user->id);


	$traduction = Ocelles::getTraduction($key,Yii::app()->user->id);


	$palette = Ocelles::loadPalette($key,Yii::app()->user->id);


	?>


	<div class="proche <?php echo $palette;?> n2">


		<div style="float:left;width:30px;height:20px;">


		<?php if ($icone) MyFunctions::displayIcone($key."/".Yii::app()->par->TN4_PREFIX.$icone,$concept,$concept);?>


		</div>


		<?php if ($traduction) MyFunctions::displayTraduction($traduction["traductionid"],"traduction survol_video");?>


		<?php echo CHtml::link($concept,array('contenu/view','id'=>$key),array('id'=>$key,"title"=>$concept));?>


	</div>


<?php


}


?>

</div>

and error is

Erreur 500

Trying to get property of non-object

i don’t know why it showing this error and also it didn’t show path for error.