So here I have to specify that the menu item has active class if the controller id is news. So this also keeps the menu item active for url /news/view
However I recall in the previous menu implementation in Yii 1.0 (MainMenu widget) it did this automatically, i.e. it determines what the controller is based on the link url/route (so you do not need to specify ‘active’ property). The menu item is active for all of its own actions without having to specify the ‘active’ property.
Any reason why this functionality would have been removed from CMenu widget in Yii 1.1?
Yes that’s right. That basically means if I specify ‘url’=>array(’/news/index’) and do not specify the active property then the list item will be active for this URL, but ONLY this URL.
In MainMenu widget the item would be active for all of its controller actions. For example:
array('label'=>'Users, 'url'=>array('/user')),
In the view the item would be active for all ‘User’ controller actions.
That’s not quite right. The MainMenu required both the url and all _GET parameters to be equal (only the order did not matter) to those defined for the menu item.
So your example would only highlight the ‘Users’ menu item if the url equals http:://mydomain.xxx?r=/user. If a _GET parameter is added or the route is expanded (e.g. r=/user/view), then the ‘Users’ menu is no longer highlighted.
Hmm… GSTAR method doesnt work on me. Maybe I should use url rewrite instead of the default index.php?controller/action&id or maybe it works if I use nested CMenu instead of separate submenu on different instance of CMenu?
When I used yours (no matter, if with or without “?true:false” part) I got error saying: “Using $this when not in object context”. Probably, because my menu generation is involved into few functions and isn’t just a plain array.
function isItemActive ($route,$id)
{
//explode the route ($route format example: /site/contact)
$menu = explode("/",$route);
//compare the first array element to the $id passed
return $menu[0] == $id ? true:false;
}
Thanks for your solution. But - as I mentioned in a similar thread - I can’t use it in my current project. I split menu generation into two separate files and involved a few functions to generate it. At some point of doing so I had to make some some logic or organisational mistake as right now I can’t use $this in active, because I’m getting error saying that I’m trying to use $this in non-object context. Since GSTAR’s solution is working for me right now and I’m bloated with many, many other problems to be solved ASAP in current project I moved looking for what is causing this in to a bit later part of my project timeline.
But thanks again (and +1) for bringing another solution that can be useful in some other projects or can be reused by other developers.
Since this is your first post, welcome to the forum and happy Yii-ing! :]
Even if your code works fine, it is a very bad idea to change anything in the framework core code! In your situation, an extension to CMenu, an own class descending from it would be an option. If it is worth doing so (and I don’t see reasons).
There are guys out there, in a Dev Team, that are working on Yii for nearly 2,5 year now, I think they’re a little bit more experienced coders than you, and believe me - if they would find a better solution then using isMenuActive they would do this. First reason, for leaving it as it is, that comes to my mind is object-oriented programming idea (essence) that is - extendibility. With current implementation one can extend base CMenu class and write own, completely different implementation of this function. Leaving it your way makes other not possible to use this approach.
I have a "user" module. Using the standard structure in the default layout file generated by Yii, the following does not work for a module, and no "active" class is added to the link when viewing the page:
Using mbmenu I was having trouble getting the parent of a dropdown children stay active when using static pages as defined at: yiiframework: how-to-display-static-pages-in-yii/.
