CHttpRequest - Rewrite rule behaviour change

Maxximus · January 11, 2009, 10:40pm

It seems the rewrite rule:



RewriteRule ^(es|en|zh)/?(.*)    index.php/$2?lang=$1 [QSA,L]

Is not working anymore. It seems to be a behaviour change since Yii 1.0.1. CHttpRequest uses $_SERVER['REQUEST_URI'] now in favour of $_SERVER['PATH_INFO'].

Unfortunately is REQUEST_URI not modified by the rewrite rule, so now Yii tries to find a non-existent controller (es for example). So far I could not find a solution.

qiang · January 12, 2009, 12:24am

Yes, that's the change introduced in 1.0.1. The reason is that PATH_INFO is not always reliable. Could you please post your $_SERVER content and the requested URL?

Maxximus · January 12, 2009, 10:35am

True, PATH_INFO is not always available. Unfortunately the REQUEST_URI will not reflect changes made by the Rewrite engine.

I use the rewrite rule to get improved SEO results for multilang sites.

Here $_SERVER after RewriteRule (local machine, so no GEOIP available):

Even REDIRECT_URL is not reflecting any change. Could it be a solution to prevail PATH_INFO if available? Perhaps with a switch in urlManager?

qiang · January 12, 2009, 12:25pm

What is the requested URL?

Maxximus · January 12, 2009, 1:10pm

request url is: http://testdrive/es/ (in the above case http://testdrive/es but Apache will add the /)

Rewrite rule makes the QUERY_STRING correctly. In PATH_INFO is the rewritten URI, but not in REQUEST_URI.

Response is: The requested controller "es" does not exist.

Maxximus · January 12, 2009, 1:26pm

Might be solvable with a rule in urlManager, only thing I have to define my existing rules twice, and customize createUrl.

qiang · January 12, 2009, 2:35pm

A simple fix is in your index.php, add the following line before running app:

$_SERVER['REQUEST_URI']=$_SERVER['PATH_INFO'];

The current implementation (v1.0.1) is close to what ZF is doing, which I think is better than our earlier implementation (v1.0.0). But still, there may be situations like yours occur.

Maxximus · January 12, 2009, 3:04pm

Yes, that works too. Will use that for now.

Current implementation will not allow any rewrite redirection without this workaround unfortunately.

qiang · January 12, 2009, 3:16pm

Yes, rewriting rules are really tricky because they could easily turn down the default behavior of frameworks. We will see if there's any other reports about this problem and check if we could provide a better solution.

system · January 14, 2009, 9:32pm

I'd like to see the built-in support for redirect rules as I think it's quite common to use them for SEO purposes. In some cases it's better to use paths instead of query parameters - search engines like that.

qiang · January 14, 2009, 9:36pm

Check this: http://www.yiiframew…uide/topics.url

system · January 15, 2009, 3:44am

Ok, if you have a rewrite rule like in the first post, then what would you do without using a workaround (assigning path_info to request_uri)? My point is to have embedded framework support so there is no need in any workarounds.

qiang · January 15, 2009, 11:09pm

Yes, I am thinking to add an option to allow using $_SERVER['PATH_INFO']. This depends on how many requests for this feature we receive, though.

Kolyunya · June 4, 2014, 11:42am

I’ve ran inro the exactly same problem. And I vote up for adding the support of $_SERVER['PATH_INFO'] to the framework core.

eraclioramirez · August 12, 2014, 8:06pm

Agree with that!