Bad Request (#400) - Getting started Tutorial

chdrsto · December 18, 2021, 6:39pm

Hi there,
Im new at yii and followed the tutorial guide.
I have an issue at the last step, while using Gii code generator.

The system created the code using CRUD, but it seems that it isnt working correctly. The database entries are listed and I can even add a new entry in the DB, but when I try to update, delete or view a single entry, it throws me an yii\web\BadRequestHttpException: Missing required parameters: code i error when clicking on the icon for updating, deleting or viewing

softark · December 19, 2021, 12:08am

Hi @chdrsto, welcome to the forum.

Sounds very strange. Might be a bug in Gii.

Could you show us what urls the icons represent? For example, what url does the “view” icon has?

And, one more thing, could you show us the schema for the country table?

chdrsto · December 19, 2021, 8:00am

Hi @softark , thanks for answering.
The icons are pointing to following urls on one entry (it seems that new user can only post two links)

Server is : http://localhost:8080/

view = http://localhost:8080/index.php?r=country%2Fview&id=SR
update = … /index.php?r=country%2Fupdate&id=SR
delete = … /index.php?r=country%2Fdelete&id=SR

It is a MariaDB with following schema:
Greenshot 2021-12-19 08.56.12

softark · December 19, 2021, 9:55am

Thank you.

It seems like a bug in Gii’s CRUD generator.
The country/index page creates a URL of “country/view?id=SR” for the view page of “SR”, but it should be “country/view?code=SR” because the PK is ‘code’.

One quick (and dirty) workaround might be renaming the parameter of actionView():

// pubulic function actionView($code)
pubulic function actionView($id)
{
    return $this->render('view', [
        // 'model' => $this->findModel($code),
        'model' => $this->findModel($id),
    ]);
}

I will examine the problem a little further. My guess is that the Gii’s CRUD generator might fail to produce the right code when the model’s PK is not ‘id’.

softark · December 19, 2021, 10:44am

github.com/yiisoft/yii2

ActionColumn wrong primary key

opened 09:15PM - 13 Nov 21 UTC

migmam

type:bug status:ready for adoption

ActionColumn creates wrong urls If the primary key of the table is not named "id…" The source code (ActionColumn.php) shows: ``` public function createUrl($action, $model, $key, $index) { echo $key; echo $index; print_r($model); if (is_callable($this->urlCreator)) { return call_user_func($this->urlCreator, $action, $model, $key, $index, $this); } $params = is_array($key) ? $key : ['id' => (string) $key]; $params[0] = $this->controller ? $this->controller . '/' . $action : $action; return Url::toRoute($params); } ``` So the line $params = is_array($key) ? $key : [**'id'** => (string) $key]; is always creating url with id as parameter. The workaround that worked for me is: ``` if( isset($model->primaryKey) ) $params = is_array($key) ? $key : [$model->primaryKey => (string) $key]; else $params = is_array($key) ? $key : ['id' => (string) $key]; ```

Oh, this is it.
Not a bug of Gii, but a bug in yii\grid\ActionColumn.

chdrsto · December 19, 2021, 11:07am

Thanks for your lookup on github.
It is funny that I’m the first one who trapped into that bug while doing the tutorial
Anyway, it was interesting to start with debugging eventhough I had no idea on what am I doing

softark · December 19, 2021, 11:41am

I also have no idea why this bug has been hidden from many people for this long.
Has there been no one that faithfully followed the tutorial step by step before you?
Good grief.